Classes #2813
Classes #2813
Conversation
instead of `Node.prototype.method.call(this, ...args)`
✅ Deploy Preview for stylus-docs canceled.
|
|
Can you add deno test for this pr? Thanks ! For Stylus, this is a significant change, so it also implies that it's unlikely to complete the review and merge in a short period of time. Perhaps we should also consider releasing an alpha version to test community feedback. @vixalien |
property assignment doesn't work on node v10-12
|
@iChenLei I added deno tests. And yes, I can see this is a huge PR and will need time to review. you can release an alpha if necessary. also note that the build still fails because of |
Could you help with downgrading @adobe/css-tools to support Node 10+? Using a fixed version might be a good approach, but I'm also considering whether to raise Stylus support to Node 14+. And again, big thanks to you. |
Downgraded
If you do so, I could work on bringing ES Modules support to stylus if that's desirable
no worries! thank you too for taking care of this PR and giving feedback |
|
excellent work ! @vixalien |
* fix super call in object.js the super.operate.call syntax doesn't pass in the `this` argument. The code before the classes #2813 PR was: ```js Node.prototype.operate.call(this, op, right) ``` and the code was incorrectly transformed into ```js super.operate.call(op, right); ``` * directly call super methods instead of doing `super.method.call(this, ...args)` * chore: add test cases * chore: add eos --------- Co-authored-by: Angelo Verlain <geoangercola@gmail.com>
What:
Use
classthroughout the project instead of using.prototype.__proto__Why:
As talked about in #2745, Classes are better supported than
__proto__. And this brings stylus on track to have a good and up-to-date codebase.Checklist: